Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Serializer and Index Complexity #107

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Reduce Serializer and Index Complexity #107

merged 11 commits into from
Oct 22, 2024

Conversation

halgari
Copy link
Contributor

@halgari halgari commented Oct 21, 2024

This PR does the following:

  • Reworks serializers to use static classes instead of large switch statements
  • Merges indexes into a single large index that is sorted first by index type
    • Removes the need for column families and cross KV store transactions (something only RocksDB supports)
  • Simplifies many of the APIs around indexes, SliceDescriptors and the store backends

erri120
erri120 requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@halgari halgari merged commit dca14f6 into main Oct 22, 2024
4 checks passed
@halgari halgari deleted the reduce-batch-methods branch October 22, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erri120 erri120 erri120 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halgari @erri120